Added an option to not automatically instantiate a Log object.#6
Open
jonasbjurel wants to merge 127 commits intomrRobot62:masterfrom
Open
Added an option to not automatically instantiate a Log object.#6jonasbjurel wants to merge 127 commits intomrRobot62:masterfrom
jonasbjurel wants to merge 127 commits intomrRobot62:masterfrom
Conversation
Make ArduinoLog work on native (x86_64) environments for testing
- Added PGM stubs - Use Arduino.h in most cases
Explanation printable object in README.md
Added advanced example
Renamed basic example Updated & cleaned up examples
… "Don't cast the va_arg for __FlashStringHelper* or char* because it crashes on x86"
This avoids error: '_logOutput' was not declared in this scope when DISABLE_LOGGING is defined.
Private _logOutput conditional compilation when DISABLE_LOGGING
Fix: clearSuffix was clearing the prefix instead of the suffix
Fix: clearSuffix was clearing the prefix
In some cases you do not want the Log object to be instantiated automatically by the library. Reasons could be that you want to control the heap memory segment type that gets allocated for the log object, or that you want to inherit the log base to another derived class. This commit adds a flag "__DO_NOT_INSTANTIATE__" that if set omits the automatic instantiation. The change is backwards compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases you do not want the Log object to be instantiated automatically by the library.
Reasons could be that you want to control the heap memory segment type that gets allocated for the log object, or that you want to inherit the log base to another derived class.
This commit adds a flag "DO_NOT_INSTANTIATE" that if set omits the automatic instantiation.
The change is backwards compatible.