Replace FrameSource with lightweight PyAV decode for thumbnails#960
Merged
Replace FrameSource with lightweight PyAV decode for thumbnails#960
Conversation
get_initial_thumbnails() was creating a full FrameSource per camera, which runs a keyframe scan of the entire video file. Thumbnails only need the first frame. Now opens the container, decodes one frame, and closes — no keyframe scan, no reopen cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_initial_thumbnails()was creating a fullFrameSourceper camera just to grab the first frame.FrameSource.__init__runs a keyframe scan of the entire video file, which is unnecessary for thumbnails.av.open(), decodes one frame, and closes. No keyframe scan, no close-and-reopen cycle.MultiCameraProcessingTabconstruction dropped from ~710ms to ~80ms on a 5-camera project.