Migrate read_video_properties from OpenCV to PyAV#959
Merged
Conversation
Replaces cv2.VideoCapture with av.open() for video metadata extraction, eliminating the last OpenCV video I/O in production code. OpenCV's CAP_PROP_FRAME_COUNT returns -1 for codecs it doesn't fully support; PyAV wraps FFmpeg directly and handles all codecs consistently. - Rewrite video_utils.py to use av.open() + stream metadata - Add duration-based frame count fallback (matches FrameSource) - Wrap PyAV exceptions as ValueError (preserves caller contract) - Guard frame_count <= 0 in from_videos() (defense-in-depth) - Add error-case tests for FileNotFoundError and ValueError
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cv2.VideoCapturewithav.open()for video metadata extraction, eliminating the last OpenCV video I/O in production codeFrameSource.frame_countlogicValueErrorto preserve the caller contract<= 0defense-in-depth guard on frame count infrom_videos()FileNotFoundErrorandValueError