Migrate read_video_properties from OpenCV to PyAV#958
Closed
Conversation
Eliminates the last cv2.VideoCapture usage in production code. OpenCV's CAP_PROP_FRAME_COUNT returns -1 for unsupported codecs (e.g. APV from DaVinci Resolve), causing NaN propagation in timestamp inference. PyAV wraps FFmpeg directly and handles all codecs consistently. - Rewrite video_utils.py to use av.open() + stream metadata - Add duration-based frame count fallback (matches FrameSource) - Wrap all PyAV exceptions as ValueError (caller contract) - Fix from_videos() guard: frame_count == 0 → <= 0 - Add error-case tests for FileNotFoundError and ValueError Fixes #956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_video_properties()to use PyAV (av.open()+ stream metadata) instead ofcv2.VideoCapture, eliminating the last OpenCV video I/O usage in production codeCAP_PROP_FRAME_COUNTreturns -1 for unsupported codecs (e.g. APV from DaVinci Resolve), causing NaN propagation in timestamp inference<= 0instead of== 0) infrom_videos()for negative frame countsFixes #956