Add Adam Optimizer#317
Conversation
for more information, see https://pre-commit.ci
mphoward
left a comment
There was a problem hiding this comment.
Looks great! Here are a couple minor requests.
Co-authored-by: Michael Howard <mphoward@auburn.edu>
Add adam citation.
|
@mphoward, whenever you have a chance could you look at these failing jobs and see if you have any ideas? I don't really understand what is happening but I think it has to just be a GitHub actions issue 😅 |
|
It is surprisingly hard to spot, but based on this error: I suspect that the problem is that a different I'm not sure why this is broken all of a sudden. As a quick fix, you could try explicitly adding If that doesn't work, I have been considering moving to |
|
I've addressed all your comments, and this should be about ready to go! |
mphoward
left a comment
There was a problem hiding this comment.
Thank you, looks great!
This PR implements the Adam Optimizer. We've had enough success with this in several projects that I think it is worth adding it as an option!