Skip to content

Support GSD version 5#113

Merged
mphoward merged 2 commits into
mainfrom
fix/gsd
Apr 27, 2026
Merged

Support GSD version 5#113
mphoward merged 2 commits into
mainfrom
fix/gsd

Conversation

@clpetix
Copy link
Copy Markdown
Contributor

@clpetix clpetix commented Apr 27, 2026

This ensures that GSD v5's new validate behavior works as intended.

@clpetix clpetix self-assigned this Apr 27, 2026
@clpetix
Copy link
Copy Markdown
Contributor Author

clpetix commented Apr 27, 2026

@mphoward, I think a simple try-except block will work here! Sorry about the delay! 😅

@mphoward
Copy link
Copy Markdown
Contributor

Thanks! That's an easy small fix. However, can we implement this via the _compatibility module rather than try-except? That will make the intention of this code clear, and also we can then easily pull it back out later. Something like:

if gsd_version >= packaging.version.Version("5.0.0"):
    gsd_validate_inplace = True
else:
    gsd_validate_inplace = False

and

if _compatibility.gsd_validate_inplace:
    frame.validate(inplace=True)
else:
    frame.validate()

@clpetix
Copy link
Copy Markdown
Contributor Author

clpetix commented Apr 27, 2026

There ya go! That should work!

Copy link
Copy Markdown
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@mphoward mphoward merged commit e05dbf1 into main Apr 27, 2026
15 checks passed
@mphoward mphoward deleted the fix/gsd branch April 27, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants