Feature/dynamic bonding#124
Conversation
first working bond finding algorithm between two groups, looks up neighbours from neighbour list does not create duplicate bonds, does not segfault
…lab/azplugins into feature/dynamic-bonding
| } | ||
|
|
||
|
|
||
| // @mphoward: This is the function that I originally had that doesn't work anymore due to |
There was a problem hiding this comment.
This error is most likely coming up due to a change in when an array is acquired. See the discussion here and try to backtrack:
|
This is now implemented on the CPU and GPU, code still needs cleanup. It passes the non-MPI unit tests, which make sense, I think bigger modifications for MPI might be needed because of the global loop over all possible bonds when they are formed. We might just want to say that this module doesn't work for MPI. @mphoward what do you think about supporting MPI? I haven't thought about how one would do it because we would need to think about how to handle the system wide for loop over all possible bonds to form them sequentially. |
|
Great! For azplugins features, I am perfectly fine with not supporting MPI if it is not needed for your research. In this case, please make clear in the documentation with a note or warning that MPI is not supported, then add error checking at the Python and C++ level for running on multiple ranks. If you envision using this code on multiple CPUs, I am also happy to take a look to see if I can suggest how to support MPI. |
This is the current state of the dynamic bonding code which I need some feedback and help on, @mphoward. The plan is to test hoomd 5.4.0 and cuda/12.6 first before moving it to hoomd 6.0, although it doesn't compile currently on the GPU. The CPU code works and is mostly tested.
The two big roadblocks are currently:
Still todo before this can be merged: