Skip to content

Fix writing byte_alignment() in slice_header and rbsp_slice_trailing_bits() in slice_layer_rbsp() #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jamrial wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix writing byte_alignment() in slice_header and rbsp_slice_trailing_bits() in slice_layer_rbsp() #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9311b47
Fix writing byte_alignment() in slice_header
jamrial Feb 24, 2026
9ad6280
Fix writing rbsp_slice_trailing_bits() in slice_layer_rbsp()
jamrial Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src_base/xeve_eco.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ int xeve_eco_sh(XEVE_BSW *bs, XEVE_SPS *sps, XEVE_PPS *pps, XEVE_SH *sh, int nut

/* byte align */
u32 t0 = 0;
xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, t0);
}
Expand Down
8 changes: 8 additions & 0 deletions src_base/xeve_enc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,10 +546,18 @@ int xeve_pic(XEVE_CTX* ctx, XEVE_BITB* bitb, XEVE_STAT* stat)
bin_counts_in_units += tmp_sbac->bin_counter;
total_tiles_in_slice--;

// byte_alignment() should be here for all tiles but the last
// when the slice has more than one tile.

sh->entry_point_offset_minus1[k - 1] =
(u32)((bs)->cur - bs_beg.cur - 4 + (4 - (bs->leftbits >> 3)) + (bs_beg.leftbits >> 3) - 1);
} // End to tile encoding loop in a slice

xeve_bsw_write1(bs, 1);
while(!XEVE_BSW_IS_BYTE_ALIGN(bs)) {
xeve_bsw_write1(bs, 0);
}

num_bytes_in_units = (int)(bs->cur - cur_tmp) - 4;

int log2_sub_wh_c = 2;
Expand Down