Explicitly list all .el files in Makefile#20
Merged
DamienCassou merged 1 commit intompdel:masterfrom Sep 22, 2025
Merged
Conversation
DamienCassou
approved these changes
Sep 22, 2025
Contributor
DamienCassou
left a comment
DamienCassou
left a comment
There was a problem hiding this comment.
Thank you very much. I will merge the PR. That being said, I don't think Guix should lint the code: I don't think it is its responsibility. I would suggest running make test to run the unit tests only instead of make check which also runs linting.
This prevents the linter from getting tripped up by an auto-generated libmpdel-pkg.el file.
DamienCassou
force-pushed
the
explicitly-list-el-files
branch
from
3c593ca to
e2d9521
Compare
DamienCassou
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When (lib)mpdel is built for guix, a (lib)mpdel-pkg.el file is
auto-generated - this trips up the linter, since it doesn't have the
conventional header comments. By explicitly listing which .el files
to include, this can be prevented. I suspect that this also happens
on some other platforms, but don't know for sure