Conversation
DamienCassou
left a comment
There was a problem hiding this comment.
Thank you for decomposing your PR. Can you please have a look at my feedback? Is there anything to update in the README?
|
and as to the readme: This does not introduce any new data types, and since many of the fields of |
DamienCassou
left a comment
There was a problem hiding this comment.
This looks good to me. Can we add a unit test or two?
As for #17, please sign your commits if you can.
DamienCassou
left a comment
There was a problem hiding this comment.
Excellent. Do you plan to sign your commits or should I move forward without?
|
I plan to sign them, just have to figure out how to set that up |
you may want to read this: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits |
|
Thanks for the link, I signed the commits |
DamienCassou
left a comment
There was a problem hiding this comment.
Excellent! Thank you
No description provided.