fix: push method deprecation in Apptentive mParticle integration#27
Open
frankus wants to merge 1 commit intomparticle-integrations:developmentfrom
Open
fix: push method deprecation in Apptentive mParticle integration#27frankus wants to merge 1 commit intomparticle-integrations:developmentfrom
frankus wants to merge 1 commit intomparticle-integrations:developmentfrom
Conversation
frankus
force-pushed
the
fix/push-method-deprecation
branch
from
a7a396e to
147ee71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces a formerly-deprecated method call with its replacement, since the deprecated method call is being removed entirely in our next major release.
Testing Plan
I attempted to test this locally. This change does fix the build error that arises when using the forthcoming 7.0 version of our SDK, but I was not able to get the mParticle shared instance to forward the push device token to our kit for an end-to-end test.