Skip to content

Show loader for disabled checkbox for download-as-default landing page - WT127 (fix #433)#905

Closed
wen-2018 wants to merge 4 commits intomainfrom
ui-improvement-for-landing-checkbox
Closed

Show loader for disabled checkbox for download-as-default landing page - WT127 (fix #433)#905
wen-2018 wants to merge 4 commits intomainfrom
ui-improvement-for-landing-checkbox

Conversation

@wen-2018
Copy link
Copy Markdown
Collaborator

@wen-2018 wen-2018 commented Jan 16, 2026

One-line summary

This PR adds a loader for temporarily disabled checkbox for Windows landing page download-as-default option.

Significant changes and points to review

Firefox on Windows landing page download-as-default checkbox.

Issue / Bugzilla link

https://mozilla-hub.atlassian.net/browse/WT-127?atlOrigin=eyJpIjoiMjgyY2E5YThjOWU2NGRmMWI1MzliMjE4YmYwYzY0ODgiLCJwIjoiaiJ9
#433

Testing

http://localhost:8000/en-US Firefox on Windows

@wen-2018 wen-2018 added the WIP Work in progress label Jan 16, 2026
@wen-2018 wen-2018 force-pushed the ui-improvement-for-landing-checkbox branch 2 times, most recently from 7030c8b to 9e131b0 Compare January 19, 2026 16:26
@wen-2018 wen-2018 changed the title animation experiment Show loader for disabled checkbox for download-as-default landing page Jan 19, 2026
@wen-2018 wen-2018 changed the title Show loader for disabled checkbox for download-as-default landing page Show loader for disabled checkbox for download-as-default landing page - WT127 (fix #433) Jan 19, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.81%. Comparing base (2f685c4) to head (41ca15f).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   77.81%   77.81%           
=======================================
  Files         131      131           
  Lines        8091     8091           
=======================================
  Hits         6296     6296           
  Misses       1795     1795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wen-2018 wen-2018 force-pushed the ui-improvement-for-landing-checkbox branch from 9e131b0 to 5423ebf Compare January 19, 2026 16:36
@wen-2018 wen-2018 added Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review and removed WIP Work in progress labels Jan 19, 2026
@wen-2018 wen-2018 marked this pull request as ready for review January 19, 2026 17:02
@maureenlholland maureenlholland self-assigned this Feb 11, 2026
Copy link
Copy Markdown
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested change: spinner animation with no layout shift

suggested changes are non-blocking

Comment thread media/js/firefox/download/desktop/download-as-default.es6.js Outdated
Comment thread media/js/firefox/download/desktop/download-as-default.es6.js Outdated
Comment thread media/css/firefox/home.scss Outdated
@maureenlholland maureenlholland removed the Needs Review Awaiting code review label Feb 11, 2026
@wen-2018 wen-2018 force-pushed the ui-improvement-for-landing-checkbox branch from 53aa3c4 to 68ca0f1 Compare March 11, 2026 14:57
@maureenlholland
Copy link
Copy Markdown
Collaborator

@wen-2018 I'm inclined to close this as outdated. We've turned off the download-as-default checkbox for now and the home page has moved to CMS.

It might be worth moving to a more systematized feature related to Flare26. We might want to formalize some standard UI loading options in context of buttons and checkboxes

@wen-2018
Copy link
Copy Markdown
Collaborator Author

Closed as it is outdated.

@wen-2018 wen-2018 closed this Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend HTML, CSS, JS... client side stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants