Skip to content

page meta title tweaks - WT118 (fix #385)#900

Merged
wen-2018 merged 4 commits intomainfrom
page-title-tweaks
Mar 16, 2026
Merged

page meta title tweaks - WT118 (fix #385)#900
wen-2018 merged 4 commits intomainfrom
page-title-tweaks

Conversation

@wen-2018
Copy link
Copy Markdown
Collaborator

@wen-2018 wen-2018 commented Jan 9, 2026

One-line summary

This PR updates some page titles to avoid repetition.

Significant changes and points to review

/browsers/mobile/ios/
/browsers/desktop/
/browsers/mobile/

meta title

Issue / Bugzilla link

#385

Testing

http://localhost:8000/browsers/mobile/ios/
http://localhost:8000/browsers/desktop/
http://localhost:8000/browsers/mobile/

@wen-2018 wen-2018 marked this pull request as ready for review January 12, 2026 20:14
Copy link
Copy Markdown
Collaborator

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this was discussed before feel free to disregard the comments, I just thought I'd leave here what I felt could be the options when looking into the differences:

(Also wondering, how to differentiate UK vs. US titles a slightly more, like using "from" vs. "by" in them, but leaving that for a reviewer better equipped for language tweaks;D)

Comment thread springfield/firefox/templates/firefox/browsers/desktop/index.html Outdated
Comment thread springfield/firefox/templates/firefox/browsers/desktop/index.html Outdated
Comment thread springfield/firefox/templates/firefox/browsers/mobile/ios.html Outdated
Comment thread springfield/firefox/templates/firefox/browsers/mobile/ios.html Outdated
Comment thread springfield/firefox/templates/firefox/browsers/mobile/ios.html Outdated
Comment thread springfield/firefox/templates/firefox/download/desktop/base.html Outdated
Comment thread springfield/firefox/templates/firefox/download/desktop/base.html Outdated
@wen-2018 wen-2018 added Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review labels Jan 14, 2026
Copy link
Copy Markdown
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Jan's comments that we should use by Mozilla to avoid too much Firefox repetition

@maureenlholland maureenlholland removed the Needs Review Awaiting code review label Feb 11, 2026
@maureenlholland maureenlholland self-assigned this Feb 11, 2026
@janbrasna
Copy link
Copy Markdown
Collaborator

janbrasna commented Feb 13, 2026

I had some notes originally in #385 — with perhaps a little more intricate disambiguation for some of the key pages, also with ideas about moving the prefix+suffix 3-section titles in some places to just 2-section content when customizing. Also /browsers/mobile does not appear to use the same way of separating the different English variations to help them not get duped against each other in search results. Ah I see mobile/index does not disambiguate but then deeper e.g. mobile/ios does so it's probably fine at that level.

Not sure if there's e.g. meta content already available for what should end up in the CMS versions of the pages, to use that as an inspiration for updates to the static templates as well?

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.82%. Comparing base (953de46) to head (00c6923).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   77.82%   77.82%           
=======================================
  Files         131      131           
  Lines        8093     8093           
=======================================
  Hits         6298     6298           
  Misses       1795     1795           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wen-2018 wen-2018 force-pushed the page-title-tweaks branch from 3918b1b to 9c49605 Compare March 11, 2026 13:36
Copy link
Copy Markdown
Collaborator

@maureenlholland maureenlholland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc ✅

non-blocking, we could update cms/base-flare26.html to use the same Firefox.com as base-protocol.html

@wen-2018 wen-2018 force-pushed the page-title-tweaks branch from 9c49605 to 00c6923 Compare March 16, 2026 19:30
@wen-2018 wen-2018 merged commit 1aa8d0b into main Mar 16, 2026
5 checks passed
@wen-2018 wen-2018 deleted the page-title-tweaks branch March 16, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend HTML, CSS, JS... client side stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants