Skip to content

Fix some playwright tests#1068

Merged
maribedran merged 41 commits intomainfrom
playwright-tests
Mar 7, 2026
Merged

Fix some playwright tests#1068
maribedran merged 41 commits intomainfrom
playwright-tests

Conversation

@maribedran
Copy link
Copy Markdown
Collaborator

One-line summary

Significant changes and points to review

Issue / Bugzilla link

Testing

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.32%. Comparing base (6c560b5) to head (eb519d2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1068      +/-   ##
==========================================
- Coverage   77.38%   77.32%   -0.06%     
==========================================
  Files         124      125       +1     
  Lines        7657     7794     +137     
==========================================
+ Hits         5925     6027     +102     
- Misses       1732     1767      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unsupported-macro failures are legit, I'll write up the instances / differences.

For now wondering how to reasonably skip environments (by URL?) that don't have some of the necessary stub pages exposed on the right URLs; but still at least run once reaching prod.

Leaving some notes for reviewer:

Comment thread tests/playwright/specs/products/firefox/firefox-android.spec.js Outdated
Comment thread springfield/cms/templates/cms/includes/flare26-menus/resources.html Outdated
Comment thread tests/playwright/scripts/open-page.js
Comment thread tests/playwright/specs/products/firefox/firefox-download.spec.js Outdated
Comment thread tests/playwright/specs/navigation.spec.js Outdated
@lucianoratamero lucianoratamero self-assigned this Mar 3, 2026
Copilot AI review requested due to automatic review settings March 5, 2026 00:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

Copilot AI review requested due to automatic review settings March 5, 2026 19:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI review requested due to automatic review settings March 7, 2026 01:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 32 changed files in this pull request and generated 8 comments.

Comment thread tests/playwright/specs/navigation.spec.js
Comment thread tests/playwright/specs/navigation.spec.js
Comment thread tests/playwright/specs/products/firefox/firefox-android.spec.js Outdated
Comment thread tests/playwright/specs/products/firefox/firefox-ios.spec.js
Comment thread springfield/cms/templates/cms/includes/flare26-menus/browser.html Outdated
Comment thread tests/redirects/test_redirects.py
Comment thread springfield/cms/tests/test_blocks.py Outdated
Comment thread springfield/cms/templates/components/download-firefox-button.html
maribedran and others added 2 commits March 6, 2026 22:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 7, 2026 01:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 31 out of 32 changed files in this pull request and generated 3 comments.

Comment thread springfield/base/templates/includes/navigation/menus/resources.html
Comment thread springfield/cms/tests/test_blocks.py
Comment thread springfield/base/templates/includes/navigation/navigation.html
@maribedran maribedran merged commit bb0648c into main Mar 7, 2026
3 checks passed
@maribedran maribedran deleted the playwright-tests branch March 7, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants