Add parallel PR CI including collectstatic check#1012
Open
janbrasna wants to merge 1 commit intomozmeao:mainfrom
Open
Add parallel PR CI including collectstatic check#1012janbrasna wants to merge 1 commit intomozmeao:mainfrom
janbrasna wants to merge 1 commit intomozmeao:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line summary
To evaluate a more comprehensive CI make target I figured adding that in parallel to the current pipeline could help assess if the extra 40–60sec spent on it is worth it.
Significant changes and points to review
This will now run both
make test-imageandmake test-ciside by side. It's a waste of CPU cycles, but is actually great to see the difference over the span of a week or two to see the range of durations this tends to have (between 6–8mins usually), when triggered on the same event at the same time.(The difference between the two make targets is covered in the linked tickets. TL;DR is: the added strict collectstatic check is implicitly achieved by running a target including
releaseservice in its build.)The idea is to move the original
make test-imagejob to usemake test-cieventually if this proves useful.(NB: For preview purposes, this duplicate pipeline is only run on PRs, not again on main, as it's just waste of cycles at this point, the same will be done in CD pipeline.)
Issue / Bugzilla link
mozilla/bedrock#16495
mozilla/bedrock#16918
Testing
This actual PR already shows the modified CI run:
/actions/runs/22188873820 ✅✅✅
(NB: These start at the same time, so the result doesn't come 8mins later, but just less than a minute later — it only adds 40–60s to the overall CI span running in parallel, not its whole run time.)
Example of missing asset caught:
@janbrasna/springfield/actions/runs/22175415059 ❌