Bug 1944375 - Improve data cycling for TryDataRemoval #9158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmierz
approved these changes
Jan 12, 2026
| ), | ||
| del_replicate AS ( | ||
| DELETE FROM performance_datum_replicate r1 | ||
| WHERE r1.performance_datum_id IN ( |
Collaborator
There was a problem hiding this comment.
nit: It would be good to explain this WHERE condition in the comment above. At first glance, it looks like it's redundant since we do a similar select query above for target_datum.
junngo
force-pushed
the
improve-cycle-data-try
branch
from
5248bb0 to
50a8b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this PR for TryDataRemoval out of #9136.
I added a brief comment in
__attempt_removeto explain the intent without going into too much detail.If more context would be helpful, please feel free to let me know. And of course, if anything needs to be changed, I’m happy to update it.