Skip to content
This repository was archived by the owner on Jul 31, 2019. It is now read-only.

Conversation

@IamHDT
Copy link

@IamHDT IamHDT commented Sep 12, 2017

Fixes #1918!

Looks like the solution on #2022 is incorrect, So I submit another pull request to fix.

Change Publish popup title when project is Live
@flukeout
Copy link
Contributor

Hey @IamHDT - thank you for submitting. Overall, our goal in seeking contributions is to assist and help people work through a problem until they reach a solution. In the future, could you please check to make sure that the original submitter has given up or is no longer working on it?

In the case #2022 - it has been sitting for a while and we were slow to act on it, so there's a good chance that @rkgupta21 has stopped working on it.

If you'd like to tackle an issue, please leave a comment on it and we'll add an Assigned to Contributor label so that multiple people don't try to solve it at once, which can get awkward.

OK - thanks for understanding. In the case of your PR, a suggestion I have it to change showing and hiding elements by adding or removing a single class like .published to the entire dialog. Then, show and hide the appropriate pieces via CSS. This reduces the code complexity and lets us make changes down the road for other elements without having to alter the Javascript.

Thank you!

Copy link
Contributor

@flukeout flukeout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the requested changes in the comment I left. Thank you.

@IamHDT
Copy link
Author

IamHDT commented Sep 14, 2017

@flukeout OK. I will do.

@IamHDT IamHDT closed this Sep 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change Publish popup title when project is Live

3 participants