Changes to the feature ID list, getAndroidBranchInfo, and getAndroidDashboardLink #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fxms-skylight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarahhjchung
commented
Apr 16, 2025
sarahhjchung
commented
Apr 16, 2025
sarahhjchung
changed the title
AllegroFox
reviewed
Apr 16, 2025
| "whatsNewPage", | ||
|
|
||
| // Android features | ||
| "cfr", |
Collaborator
There was a problem hiding this comment.
Do we have a way to differentiate between the Desktop cfr feature and the Android one? If they're falling in the same bucket we may run into issues, though I suppose if things are also being filtered by platform that may cover it
Contributor
Author
There was a problem hiding this comment.
Yeah, I think since we check for the platform by appName before deciding to call getDesktopBranchInfo or getAndroidBranchInfo I think that would cover it
sarahhjchung
force-pushed
the
feature-ids
branch
2 times, most recently
from
1f6c9fe to
c168f0f
Compare
AllegroFox
approved these changes
Apr 16, 2025
Collaborator
AllegroFox
left a comment
AllegroFox
left a comment
There was a problem hiding this comment.
Looks great and tests are green! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
getAndroidBranchInfo, andgetAndroidDashboardLinkfrom 2nd WIP android branch #653getAndroidBranchInfo, andgetAndroidDashboardLink