Update Looker dashboard submission timestamp logic #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fxms-skylight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dmose
approved these changes
Apr 11, 2025
Member
dmose
left a comment
dmose
left a comment
There was a problem hiding this comment.
Looks good; please update the changelog too. r=dmose, with one nit
| }); | ||
|
|
||
| it("returns a correct dashboard link with defined start and end dates where the end date is in the future", () => { | ||
| const template = "feature_callout"; |
Member
There was a problem hiding this comment.
Nit: how about clarifying that the expected result here is today?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made:
getLookerSubmissionTimestampDateFilterso that any endDate that is in the future gets set to today's date to avoid issues with the dashboard showing no data for future dates (ie. this issue was found for the Viewpoint Android 2025 Rolling rollout in 2nd WIP android branch #653)