Skip to content

Ignore empty-set environment values for config#2639

Open
AJIOB wants to merge 1 commit intomozilla:mainfrom
AJIOB:fix-empty-env-var
Open

Ignore empty-set environment values for config#2639
AJIOB wants to merge 1 commit intomozilla:mainfrom
AJIOB:fix-empty-env-var

Conversation

@AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Mar 11, 2026

We face with problem on Linux, when WebDAV branch was incorrectly triggered, because the empty WebDAV endpoint was exported from Bash and incorrectly interpreted by sccache.

Error we faced:

sccache: Starting the server...
sccache: error: Server startup failed: create webdav cache failed: ConfigInvalid (permanent) at , context: \{ service: webdav } => endpoint is empty
  
Stack backtrace:
   0: <unknown>
   1: <unknown>
   2: <unknown>
   3: <unknown>
   4: <unknown>
   5: <unknown>
   6: <unknown>
   7: <unknown>

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2026

Codecov Report

❌ Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.39%. Comparing base (7b751fc) to head (f2073eb).

Files with missing lines Patch % Lines
src/config.rs 94.20% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2639      +/-   ##
==========================================
+ Coverage   73.37%   73.39%   +0.02%     
==========================================
  Files          68       68              
  Lines       37338    37355      +17     
==========================================
+ Hits        27396    27417      +21     
+ Misses       9942     9938       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AJIOB AJIOB force-pushed the fix-empty-env-var branch from a167198 to 1d36170 Compare March 11, 2026 08:44
@AJIOB
Copy link
Contributor Author

AJIOB commented Mar 18, 2026

Hi @sylvestre ,

Is this PR OK for you?

@AJIOB AJIOB force-pushed the fix-empty-env-var branch from 1d36170 to f2073eb Compare March 18, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants