Skip to content

refactor CLI code#107

Open
mykmelez wants to merge 16 commits intomozilla:masterfrom
mykmelez:refactor-cli
Open

refactor CLI code#107
mykmelez wants to merge 16 commits intomozilla:masterfrom
mykmelez:refactor-cli

Conversation

@mykmelez
Copy link
Copy Markdown
Contributor

No description provided.

@cvan
Copy link
Copy Markdown
Contributor

cvan commented Dec 15, 2017

long time no talk!

do you still need a review on this?

@mykmelez
Copy link
Copy Markdown
Contributor Author

Hey @cvan, a review would be great! I'm especially interested in your thoughts on the architectural changes, and whether they'll make it easier (or harder) to maintain and enhance this code over time.

I've updated the branch to fix the conflict with master, so it's ready for your review!

@cvan
Copy link
Copy Markdown
Contributor

cvan commented Dec 20, 2017

@mykmelez awesome, sure thing!

do you have an idea what's wrong with the Taskcluster test failures on Windows? (I recall prior issues re: PR #69; same issue or different?)

@mykmelez
Copy link
Copy Markdown
Contributor Author

do you have an idea what's wrong with the Taskcluster test failures on Windows? (I recall prior issues re: PR #69; same issue or different?)

I think this was a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1410564. I fixed it in 2b82e72, then resolved another Taskcluster failure on Windows, so the tests now pass there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants