-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Use DecompressionStream in async code #20593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use DecompressionStream in async code #20593
Conversation
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/77bebc518c72cc2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 2 Live output at: http://54.193.163.58:8877/f46340eba64b537/output.txt |
timvandermeij
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests. Thank you!
4125cd1 to
135dc88
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/ae5685c04797efe/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 3 Live output at: http://54.193.163.58:8877/8d4937a0f78a665/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/77bebc518c72cc2/output.txt Total script time: 41.25 mins
Image differences available at: http://54.241.84.105:8877/77bebc518c72cc2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ae5685c04797efe/output.txt Total script time: 41.66 mins
Image differences available at: http://54.241.84.105:8877/ae5685c04797efe/reftest-analyzer.html#web=eq.log |
ee17488 to
3490c16
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d5272622422d693/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c54f9ea5fb6e75d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c54f9ea5fb6e75d/output.txt Total script time: 41.76 mins
Image differences available at: http://54.241.84.105:8877/c54f9ea5fb6e75d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d5272622422d693/output.txt Total script time: 82.15 mins
Image differences available at: http://54.193.163.58:8877/d5272622422d693/reftest-analyzer.html#web=eq.log |
|
The differences in the XFA file are because there are 2 different fonts with the same css info (the italic angle is missing for the italic font). Because of the asynchronicity introduced in this patch, the order of the font loading is slightly different and finally make the font selection more or less correct. |
Usually, content stream or fonts are compressed using FlateDecode. So use the DecompressionStream API to decompress those streams in the async code path.
3490c16 to
9f660be
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d5c630b41c64400/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9ec255c5747fa64/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d5c630b41c64400/output.txt Total script time: 41.71 mins
Image differences available at: http://54.241.84.105:8877/d5c630b41c64400/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9ec255c5747fa64/output.txt Total script time: 81.43 mins
Image differences available at: http://54.193.163.58:8877/9ec255c5747fa64/reftest-analyzer.html#web=eq.log |
Usually, content stream or fonts are compressed using FlateDecode. So use the DecompressionStream API to decompress those streams in the async code path.