Skip to content

Conversation

@calixteman
Copy link
Contributor

Usually, content stream or fonts are compressed using FlateDecode. So use the DecompressionStream API to decompress those streams in the async code path.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/77bebc518c72cc2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/f46340eba64b537/output.txt

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thank you!

@calixteman calixteman force-pushed the decompress_content_stream branch from 4125cd1 to 135dc88 Compare January 23, 2026 21:00
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/ae5685c04797efe/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 3

Live output at: http://54.193.163.58:8877/8d4937a0f78a665/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/77bebc518c72cc2/output.txt

Total script time: 41.25 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 145

Image differences available at: http://54.241.84.105:8877/77bebc518c72cc2/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/ae5685c04797efe/output.txt

Total script time: 41.66 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 88

Image differences available at: http://54.241.84.105:8877/ae5685c04797efe/reftest-analyzer.html#web=eq.log

@calixteman calixteman force-pushed the decompress_content_stream branch 2 times, most recently from ee17488 to 3490c16 Compare January 24, 2026 14:55
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d5272622422d693/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c54f9ea5fb6e75d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/c54f9ea5fb6e75d/output.txt

Total script time: 41.76 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.241.84.105:8877/c54f9ea5fb6e75d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d5272622422d693/output.txt

Total script time: 82.15 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.193.163.58:8877/d5272622422d693/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

The differences in the XFA file are because there are 2 different fonts with the same css info (the italic angle is missing for the italic font). Because of the asynchronicity introduced in this patch, the order of the font loading is slightly different and finally make the font selection more or less correct.
Anyway, the new rendering is the correct one, but this patch can cause a potential intermittent rendering issue.
I'll try to fix the XFA bug in a follow-up.

Usually, content stream or fonts are compressed using FlateDecode.
So use the DecompressionStream API to decompress those streams
in the async code path.
@calixteman calixteman force-pushed the decompress_content_stream branch from 3490c16 to 9f660be Compare January 25, 2026 13:22
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d5c630b41c64400/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9ec255c5747fa64/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/d5c630b41c64400/output.txt

Total script time: 41.71 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.241.84.105:8877/d5c630b41c64400/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/9ec255c5747fa64/output.txt

Total script time: 81.43 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 16

Image differences available at: http://54.193.163.58:8877/9ec255c5747fa64/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 001058a into mozilla:master Jan 25, 2026
10 checks passed
@calixteman calixteman deleted the decompress_content_stream branch January 25, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants