Skip to content

Refactor a bit page mapping stuff in order to be able to support delete/copy pages #20587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
calixteman merged 1 commit into from
Jan 26, 2026
Merged

Refactor a bit page mapping stuff in order to be able to support delete/copy pages #20587

calixteman merged 1 commit into from
Jan 26, 2026
+505 −376

Conversation

@calixteman
Copy link
Contributor

@calixteman calixteman commented Jan 21, 2026

No description provided.

@calixteman
Copy link
Contributor Author

calixteman commented Jan 21, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 21, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e32fbae1f6be7aa/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 21, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/de50fcad9cfd154/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 21, 2026

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/de50fcad9cfd154/output.txt

Total script time: 23.85 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 21, 2026

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e32fbae1f6be7aa/output.txt

Total script time: 46.35 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the reorg_simplify_mapping branch from e988435 to 4e573be Compare January 22, 2026 13:44
@calixteman
Copy link
Contributor Author

calixteman commented Jan 22, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 22, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/53baf22f7fc8fb1/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 22, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dad3adcf9e88fd3/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 22, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/53baf22f7fc8fb1/output.txt

Total script time: 21.60 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments addressed and passing tests. Thank you for refactoring this; it looks simpler overall!

@calixteman calixteman force-pushed the reorg_simplify_mapping branch from 4e573be to cdc45e7 Compare January 26, 2026 15:53
@calixteman calixteman force-pushed the reorg_simplify_mapping branch from cdc45e7 to 8061333 Compare January 26, 2026 15:53
@calixteman
Copy link
Contributor Author

calixteman commented Jan 26, 2026

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 26, 2026

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4ef201351599fd4/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 26, 2026

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/764e270a3fe5616/output.txt

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 26, 2026

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4ef201351599fd4/output.txt

Total script time: 21.84 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

moz-tools-bot commented Jan 26, 2026

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/764e270a3fe5616/output.txt

Total script time: 46.43 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 07a4aab into mozilla:master Jan 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees

No one assigned

Labels

split-merge-organize

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@calixteman @moz-tools-bot @timvandermeij