fix: Fix mailto links truncated at dash #20565
Open
+11
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairosci
changed the title
Contributor
|
I also noticed a PDF with a mislinked address with a dash before the @ ( |
Author
|
@timvandermeij @calixteman PTAL, thanks! |
Modified the regex in web/autolinker.js to explicitly allow hyphens (-) in the domain part of email addresses, while maintaining the exclusion of other punctuation. This fixes mailto links like user@uni-city.tld being truncated at the hyphen. Fixes mozilla#20557
kairosci
force-pushed
the
fix-bug-20557
branch
from
01bb1eb to
50f2d4d
Compare
Author
|
Updated and formatted the linker file, updated the branch and added a single commit that describes the changes made (with multi-line description), I think that's all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
mailto:links containing hyphens in the domain part were truncated (e.g.,user@uni-city.tld->user@uni).The Fix
Modified the regex in
web/autolinker.jsto explicitly allow hyphens (-) in the domain part of email addresses, while maintaining the exclusion of other punctuation.Verification
Fixes #20557.