You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Sep 5, 2024. It is now read-only.
My use case is to synchronize two cookies, one plaintext and the other a secret.
This hook allows me to update the plaintext cookie, just as the secret one gets updated.
Would love to get this merged, but don't mind alternatives. If any spring to mind.
So, this runs a possible callback when the cookies are serialized? And the reason to do this in your case is to so that the 2 cookies are synchronized, and you don't want to forget to update the plaintext cookie accidentally?
Could this also be achieved with another middleware and override res.writeHead again?
@seanmonstar thanks for the prompt response.
Some assumptions:
We don't have access to rawSession
clientSession will only write the cookie, when rawSession#isDirty
I think decorating writeHead again isn't a bad idea. But based on the assumptions above, I would need to write my plaintext cookie on every request, as apposed to when clientSession writes its cookie. Since I don't know when the rawSession is dirty ( and needs to send a new cookie ).
Hence, I just stuck a callback into client session code. So I could know exactly when clientSession was going to write its cookie, and I could do something about, it before the headers were sent.
@seanmonstar good point!
I'll see if I can't make a workaround with that in mind, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
My use case is to synchronize two cookies, one plaintext and the other a secret.
This hook allows me to update the plaintext cookie, just as the secret one gets updated.
Would love to get this merged, but don't mind alternatives. If any spring to mind.