feat(transport): implement RESET_STREAM_AT frame#3102
Draft
mxinden wants to merge 1 commit intomozilla:mainfrom
Draft
feat(transport): implement RESET_STREAM_AT frame#3102mxinden wants to merge 1 commit intomozilla:mainfrom
mxinden wants to merge 1 commit intomozilla:mainfrom
Conversation
Contributor
Failed Interop TestsNone ❓ All resultsSucceeded Interop TestsNone ❓ Unsupported Interop TestsNone ❓ |
Member
martinthomson
left a comment
martinthomson
left a comment
There was a problem hiding this comment.
Following a link, I find this. No substance here yet, but a reasonable start.
Comment on lines
+9
to
+12
| // TODO: When using 0-RTT, both endpoints MUST remember the value of this | ||
| // transport parameter. This allows use of this extension in 0-RTT packets. When | ||
| // the server accepts 0-RTT data, the server MUST NOT disable this extension on | ||
| // the resumed connection. |
Member
There was a problem hiding this comment.
This is already handled. By "default", our check in ok_for_0rtt() checks if the new connection includes the transport parameter when the old connection did.
| GreaseQuicBit = 0x2ab2, | ||
| MinAckDelay = 0xff02_de1a, | ||
| MaxDatagramFrameSize = 0x0020, | ||
| ResetStreamAt = 0x17f7586d2cb571, |
Member
There was a problem hiding this comment.
Suggested change
| ResetStreamAt = 0x17f7586d2cb571, | |
| ResetStreamAt = 0x24, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of https://datatracker.ietf.org/doc/draft-ietf-quic-reliable-stream-reset/.
Draft only for now.