launchers: Use adb from mozbuild if not found on path (Bug 2005538) #2151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzeid
changed the title
zzzeid
requested changes
Dec 11, 2025
Collaborator
zzzeid
left a comment
zzzeid
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Can you please file a bug and reference it in the title? Otherwise lgtm!
moztcampbell
force-pushed
the
adb_mozbuild
branch
from
91905bd to
1dfc783
Compare
moztcampbell
changed the title
zzzeid
previously approved these changes
Dec 11, 2025
The macos-13 workers are deprecated so we need to update. At the same time this fixes a bug where we used system python instead of python package we installed when we built the venv.
As a convenience for Firefox developers, search the $HOME/.mozbuild path for a copy of adb if it doesn't exist on your path.
moztcampbell
force-pushed
the
adb_mozbuild
branch
from
1dfc783 to
5c201d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a convenience for Firefox developers, search the $HOME/.mozbuild path for a copy of adb if it doesn't exist on your path.