Skip to content

Replace category/event with just event_name #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fbertsch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace category/event with just event_name #634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95693d8
Replace category/event with just event_name
fbertsch Mar 8, 2023
91da8e7
Merge branch 'main' into event_naming
fbertsch Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions generator/views/funnel_analysis_view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ def _event_types_lookml(self) -> List[Dict[str, Any]]:
WHERE
{{% condition category %}} category {{% endcondition %}}
AND {{% condition event %}} event {{% endcondition %}}
AND {{% condition event_name %}} category || ' - ' || event {{% endcondition %}}
AND {{% condition property_name %}} properties.key {{% endcondition %}}
AND {{% condition property_value %}} property_value.key {{% endcondition %}}
"""
Expand All @@ -194,13 +195,22 @@ def _event_types_lookml(self) -> List[Dict[str, Any]]:
"type": "string",
"suggest_explore": "event_names",
"suggest_dimension": "event_names.category",
"hidden": "yes",
},
{
"name": "event",
"description": "The event name.",
"type": "string",
"suggest_explore": "event_names",
"suggest_dimension": "event_names.event",
"hidden": "yes",
},
{
"name": "event_name",
"description": "The full name of the category and event.",
"type": "string",
"suggest_explore": "event-names",
"suggest_dimension": "event_names.event_name",
},
{
"name": "property_name",
Expand Down Expand Up @@ -240,6 +250,7 @@ def _event_types_lookml(self) -> List[Dict[str, Any]]:
"sql": (
"SELECT category, "
" event, "
" category || ' - ' || event AS event_name, "
" property.key AS property_name, "
" property_value.key AS property_value, "
" property_value.index as property_index "
Expand All @@ -259,6 +270,11 @@ def _event_types_lookml(self) -> List[Dict[str, Any]]:
"type": "string",
"sql": "${TABLE}.event",
},
{
"name": "event_name",
"type": "string",
"sql": "${TABLE}.event_name"
},
{
"name": "property_name",
"type": "string",
Expand Down