if Prototype is loaded, remove its Array.toJSON #18
Open
edsu wants to merge 2 commits intomozilla:masterfrom
Open
if Prototype is loaded, remove its Array.toJSON #18edsu wants to merge 2 commits intomozilla:masterfrom
edsu wants to merge 2 commits intomozilla:masterfrom
Conversation
… into strings. Fixes mozilla#17
…cerns about disrupting Prototype
|
Looks like nobody is in a hurry to merge your PR at jschannel. How about we just start using it anyway? |
|
My issue was during rails 2 to rails 3 migration. We had prototype 1.6, after migrating rails included prototype 1.7 which caused the problem. I renamed the prototype js file, which solved my problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a corner case given Prototype isn't used all that often anymore, but it was a particularly nasty one to track down. It would be nice to save other people the trouble.