fix(mozcloud): reject and forward options.healthCheck fields per host api#289
Open
jbuck wants to merge 1 commit into
Open
fix(mozcloud): reject and forward options.healthCheck fields per host api#289jbuck wants to merge 1 commit into
jbuck wants to merge 1 commit into
Conversation
Chart Version PreviewThe following charts will be bumped when this PR is merged:
Apply |
… api The ingress code path silently dropped any options.healthCheck field not named requestPath or port — so host, path, and the rest of the BackendConfig surface (type, checkIntervalSec, timeoutSec, healthyThreshold, unhealthyThreshold) had no effect on the rendered BackendConfig. Schema validation now rejects gateway-only fields (host/path) on api: ingress hosts and rejects ingress-only fields on api: gateway hosts, replacing the silent drop with a clear error. The ingress template now forwards every BackendConfig-supported field. Fixes MZCLD-3322.
bdd96a5 to
916edd8
Compare
emaydeck-mozilla
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ingress code path silently dropped any options.healthCheck field not named requestPath or port — so host, path, and the rest of the BackendConfig surface (type, checkIntervalSec, timeoutSec, healthyThreshold, unhealthyThreshold) had no effect on the rendered BackendConfig. Schema validation now rejects gateway-only fields (host/path) on api: ingress hosts and rejects ingress-only fields on api: gateway hosts, replacing the silent drop with a clear error. The ingress template now forwards every BackendConfig-supported field.
Related Tickets & Documents