feat(docs): Generate README.md with helm-docs#106
Closed
jbuck wants to merge 0 commit into
Closed
Conversation
jbuck
force-pushed
the
jbuck/push-mqlvvkoltppo
branch
2 times, most recently
from
d9dae2a to
f977099
Compare
Comment on lines
+28
to
+29
| - run: uvx pre-commit run --show-diff-on-failure --color=always --all-files | ||
| shell: bash |
Contributor
There was a problem hiding this comment.
You'll definitely need to update dependencies before the unit tests will work in this step. We have a Makefile target called update-dependencies that can be run to help with this.
Contributor
There was a problem hiding this comment.
We'll also need Helm installed with the unittest plugin. I installed those and updated dependencies here if you wanted to steal it: https://github.com/mozilla/helm-charts/blob/main/.github/workflows/unit-tests.yaml#L25-L32
Although I'm sure you could do this more elegantly. :)
emaydeck-mozilla
approved these changes
Oct 28, 2025
emaydeck-mozilla
force-pushed
the
jbuck/push-mqlvvkoltppo
branch
from
644181b to
44c46f8
Compare
Contributor
|
Closing this as I need to rewrite history. I saved the diff of the parts that matter to a patch file locally, so I can recreate this again afterwards if necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses https://github.com/norwoodj/helm-docs to generate the values table. I think this could be pretty handy!