DENG-9703: STMO links lead to appropriate query templates that are populated #2313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edugfilho
commented
Sep 19, 2025
| import tippy from "./tippy"; | ||
| export let href; | ||
| export let target = ""; |
Contributor
Author
There was a problem hiding this comment.
this makes the component open the link in a new tab
edugfilho
commented
Sep 19, 2025
| sqlContent={getGleanPingQuery(selectedAppVariant.table)} | ||
| /> | ||
| </td> | ||
| <tr> |
Contributor
Author
There was a problem hiding this comment.
added a here to fix a broken layout
badboy
approved these changes
Sep 22, 2025
Member
badboy
left a comment
badboy
left a comment
There was a problem hiding this comment.
At first I was confused as the screenshot didn't show that any of the "show sql" was left, but a latter commit added that back, so I guess the screenshot is outdated.
r+! Though CI is now failing due to a lint failure.
edugfilho
force-pushed
the
deng-9708
branch
from
9e06a93 to
b5dee90
Compare
edugfilho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link also opens in a new tab now.
Pull Request checklist
fixes, if applicable)