Conversation
396e0ed to
9ebb165
Compare
c777e5e to
41251a0
Compare
2201f13 to
2cb958a
Compare
Because: - The standalone navigateWithQuery replaced reach/router's navigate() with window.location.assign/replace, which silently drops options.state. The AppContext errorHandler passes isSessionAALUpgrade state through this path for the AAL upgrade flow. This commit: - Add registerNavigate to utilities.ts that stores a navigate ref - Register the navigate function from App on mount via useEffect - navigateWithQuery uses the registered function when available, falls back to window.location before React mounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Package Changes
Route Definitions (App/index.tsx, Settings/index.tsx)
<Router basepath="/">→<Routes> + <Route path="..." element={...} /><Redirect from to noThrow />→<Route path element={<Navigate to replace />} />Navigation
Infrastructure
Test Infrastructure (mocks.tsx)
router.state.location
Issue that this pull request solves
Closes: PAY-3773
Checklist
Put an
xin the boxes that apply