Skip to content

test: Update comments and test titles in privileged-context.test.ts to match behavior#59

Merged
freema merged 1 commit intomozilla:mainfrom
juliandescottes:pr54-followup
Mar 31, 2026
Merged

test: Update comments and test titles in privileged-context.test.ts to match behavior#59
freema merged 1 commit intomozilla:mainfrom
juliandescottes:pr54-followup

Conversation

@juliandescottes
Copy link
Copy Markdown
Collaborator

Follow up to #54

@juliandescottes juliandescottes marked this pull request as draft March 30, 2026 14:09
@juliandescottes juliandescottes marked this pull request as ready for review March 30, 2026 14:19
@juliandescottes juliandescottes requested a review from freema March 30, 2026 14:19
@juliandescottes
Copy link
Copy Markdown
Collaborator Author

@freema just a quick test cleanup. I noticed we don't prettify the tests folder at the moment. Would you be open to change that or is there a good reason not to enforce consistent style on that folder?

@freema
Copy link
Copy Markdown
Collaborator

freema commented Mar 31, 2026

I primarily work commercially in Python, PHP, and C# — TypeScript is mostly my open-source language, so enforcing a formatter on tests wasn't something I was used to. But I understand it's standard practice for TypeScript repos, so no problem at all — I'll prepare a PR for it.

@freema freema merged commit e6371dc into mozilla:main Mar 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants