docs(nimbus): add comprehensive desktop targeting guide#799
Merged
jaredlockhart merged 4 commits intomainfrom Mar 19, 2026
Merged
docs(nimbus): add comprehensive desktop targeting guide#799jaredlockhart merged 4 commits intomainfrom
jaredlockhart merged 4 commits intomainfrom
Conversation
Because * Desktop has no first-class targeting guide — targeting docs are scattered across FAQ, custom-audiences, targeting-debug, and workflow pages * Android and iOS each have custom-targeting guides but desktop doesn't * Experiment creators need a single reference for targeting attributes, JEXL syntax, and how targeting works end-to-end This commit * Adds a new Desktop Targeting Guide covering how targeting works, the evaluation flow, basic vs advanced targeting, the full targeting attributes reference (sourced from TargetingContextRecorder.sys.mjs), JEXL expression syntax (sourced from mozjexl and FilterExpressions.sys.mjs), sticky targeting mechanics, first-run targeting, common patterns, the recorded targeting context telemetry ping, testing with Nimbus DevTools, and how to add new targeting options Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaredlockhart
requested review from
freshstrangemusic,
mikewilli,
relud and
yashikakhurana
as code owners
Because * The build failed due to a broken link referencing /platform-guides/desktop/onboarding-feature-desktop which doesn't exist This commit * Updates the link to use the correct slug /platform-guides/desktop/onboarding Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Because * PR review feedback from freshstrangemusic This commit * Merges enrollment/sticky into a single evaluation flow step and mentions unenrollment of existing enrollments that no longer match targeting * Breaks out homePageSettings sub-properties for consistency with os and attributionData patterns * Adds the intersect binary operator to the operators table Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
freshstrangemusic
approved these changes
Mar 19, 2026
Member
freshstrangemusic
left a comment
freshstrangemusic
left a comment
There was a problem hiding this comment.
r+ with the wording changed as we discussed
Because * The evaluation flow section should be a simple overview — sticky details belong in the dedicated Sticky Targeting section below This commit * Removes the sticky clause parenthetical from the enrollment step Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
across FAQ, custom-audiences, targeting-debug, and workflow pages
syntax, and how targeting works end-to-end
This commit
docs/platform-guides/desktop/targeting.mdcovering how targeting works, the evaluation flow, basic vs advanced targeting,
the full targeting attributes reference (sourced from
TargetingContextRecorder.sys.mjs),JEXL expression syntax (sourced from mozjexl and
FilterExpressions.sys.mjs),sticky targeting mechanics, first-run targeting, common patterns, the recorded
targeting context telemetry ping, testing with Nimbus DevTools, and how to add
new targeting options
Fixes #798