Skip to content

Bug 2012452 - Users are informed in case of an authentication failure on FELT#493

Open
jporter-dev wants to merge 1 commit intomozilla:enterprise-mainfrom
jporter-dev:enterprise-bug2012452-authentication-failure-error-report
Open

Bug 2012452 - Users are informed in case of an authentication failure on FELT#493
jporter-dev wants to merge 1 commit intomozilla:enterprise-mainfrom
jporter-dev:enterprise-bug2012452-authentication-failure-error-report

Conversation

@jporter-dev
Copy link
Collaborator

No description provided.

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request

The allowPullRequests configuration for this repository (in .taskcluster.yml on the default branch) does not allow starting tasks for this pull request.

@jporter-dev jporter-dev force-pushed the enterprise-bug2012452-authentication-failure-error-report branch from 75b71e1 to ba4e0f6 Compare March 3, 2026 14:09
@jporter-dev jporter-dev marked this pull request as ready for review March 3, 2026 15:08
@jporter-dev jporter-dev marked this pull request as draft March 3, 2026 15:25
@jporter-dev jporter-dev force-pushed the enterprise-bug2012452-authentication-failure-error-report branch from ba4e0f6 to 9c7c086 Compare March 3, 2026 18:03
@jporter-dev jporter-dev marked this pull request as ready for review March 3, 2026 18:05
@jporter-dev jporter-dev force-pushed the enterprise-bug2012452-authentication-failure-error-report branch from 9c7c086 to 21c5d6c Compare March 3, 2026 20:49
@jporter-dev jporter-dev force-pushed the enterprise-bug2012452-authentication-failure-error-report branch from 21c5d6c to 862d242 Compare March 4, 2026 14:26
@jporter-dev jporter-dev force-pushed the enterprise-bug2012452-authentication-failure-error-report branch from 862d242 to f1cbf10 Compare March 4, 2026 15:24
@jporter-dev jporter-dev requested a review from lissyx March 4, 2026 17:32
@jporter-dev
Copy link
Collaborator Author

Sorted out the marionette failures and l10n conversation

  • Bumped the two l10n identifiers where the structure was changed
  • Updated the tests to use the heading attr since the moz-message-bar uses shadow dom for its contents
  • Added test case for simpler "No Internet Connection" scenario based on netOffline and dnsNotFound2

@lissyx lissyx requested a review from 1rneh March 4, 2026 17:54
Copy link
Contributor

@gcp gcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions :P

Edit: Answered them myself, I'm good with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants