Bug 2012458 - Add policy for configuring sidebar AI providers.#473
Open
mkaply wants to merge 3 commits intomozilla:enterprise-mainfrom
Open
Bug 2012458 - Add policy for configuring sidebar AI providers.#473mkaply wants to merge 3 commits intomozilla:enterprise-mainfrom
mkaply wants to merge 3 commits intomozilla:enterprise-mainfrom
Conversation
1rneh
requested changes
Feb 26, 2026
Contributor
1rneh
left a comment
There was a problem hiding this comment.
Thanks for the patch! This is my first round of review. I wasn’t previously familiar with the GenAI system module or the sidebar integration, so these comments are based on my current understanding.
I’ve included some questions and a few concerns regarding how prompts and providers are currently being cleared.
browser/locales/en-US/browser/policies/policies-descriptions.ftl
Outdated
Show resolved
Hide resolved
browser/components/enterprisepolicies/schemas/policies-schema.json
Outdated
Show resolved
Hide resolved
browser/components/enterprisepolicies/helpers/SidebarChatPolicies.sys.mjs
Outdated
Show resolved
Hide resolved
browser/components/enterprisepolicies/schemas/policies-schema.json
Outdated
Show resolved
Hide resolved
browser/components/enterprisepolicies/helpers/SidebarChatPolicies.sys.mjs
Outdated
Show resolved
Hide resolved
browser/components/enterprisepolicies/helpers/SidebarChatPolicies.sys.mjs
Outdated
Show resolved
Hide resolved
browser/components/enterprisepolicies/helpers/SidebarChatPolicies.sys.mjs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I have a couple more things to fix, but this is basically a rewrite that makes things much simpler and will make things much easier to undo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also has a change to allow external icons to work in the sidebar.
I focused on adding/removing providers and removing prompts.
If we need to add prompts, it would be straightforward, but that wasn't part of the original requirements.