Bug 2012667 - Null out prefs that reference Mozilla servers#467
Open
gcp wants to merge 2 commits intoenterprise-mainfrom
Open
Bug 2012667 - Null out prefs that reference Mozilla servers#467gcp wants to merge 2 commits intoenterprise-mainfrom
gcp wants to merge 2 commits intoenterprise-mainfrom
Conversation
Disable the topstories feed since its backend is not available.
Contributor
Author
|
It's actually cleaner to overlay this in the branding subdir, but that means if something goes wrong with the branding, the mozilla strings are still there. That's why I prefer not to do that - don't fall back to our servers, ever. |
lissyx
approved these changes
Feb 21, 2026
Contributor
Author
|
This will break some tests: |
Skip URL construction when signon.management.page.breachAlertUrl is empty (as it is in enterprise builds), and guard the URL equality assertions in the unit test behind AppConstants.MOZ_ENTERPRISE.
gcp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable the topstories feed since its backend is not available.