Bug 2015697 - Enterprise: set updateURL to console for FELT only#443
Open
lissyx wants to merge 7 commits intomozilla:enterprise-mainfrom
Open
Bug 2015697 - Enterprise: set updateURL to console for FELT only#443lissyx wants to merge 7 commits intomozilla:enterprise-mainfrom
lissyx wants to merge 7 commits intomozilla:enterprise-mainfrom
Conversation
8b094c5 to
1bebedf
Compare
685eabd to
e946ec7
Compare
Contributor
Author
|
Some context in https://bugzilla.mozilla.org/show_bug.cgi?id=2015697#c2 |
e946ec7 to
af89d5a
Compare
gcp
requested changes
Feb 21, 2026
0ef58a1 to
f95ba84
Compare
Mossop
approved these changes
Feb 25, 2026
f95ba84 to
78f1477
Compare
1rneh
requested changes
Mar 2, 2026
Contributor
1rneh
left a comment
There was a problem hiding this comment.
I built this locally to test and I made a few observations, both shown in the following screenshots:
Expected design (theme difference irrelevant):
Actual implementation:
- The title and the spinner + "Checking for updates" UI is not in line vertically with the wordmark.
- No gap between spinner and string
- "Powered by Mozilla" is gone
- The "Checking for updates" UI might only displayed for less than half a second before the email form is shown. So in that case (which will be probably be the most prominent on) It currently looks like a glitch.
Screen.Recording.2026-03-02.at.14.58.20.mov
Contributor
Author
7426b0f to
96d4313
Compare
Contributor
Author
58e0bcd to
6f8dbd8
Compare
da7fdbd to
391b884
Compare
1rneh
requested changes
Mar 3, 2026
Contributor
1rneh
left a comment
There was a problem hiding this comment.
Since I'll be out until tomorrow afternoon, I commented on everything I noticed from another quick look.
Contributor
Author
cafd7e8 to
d06ba25
Compare
gcp
requested changes
Mar 4, 2026
1rneh
approved these changes
Mar 4, 2026
Contributor
1rneh
left a comment
There was a problem hiding this comment.
Thank you for providing the screenshots. The UI changes look very correct now :)
The remaining comments address descriptive naming of methods and some small issues with the UI state changes.
… FELT and Browser
d06ba25 to
6762e44
Compare
6762e44 to
1d3341f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








No description provided.