Skip to content

Bug 2015697 - Enterprise: set updateURL to console for FELT only#443

Open
lissyx wants to merge 7 commits intomozilla:enterprise-mainfrom
lissyx:enterprise-bug2015697_client_updates
Open

Bug 2015697 - Enterprise: set updateURL to console for FELT only#443
lissyx wants to merge 7 commits intomozilla:enterprise-mainfrom
lissyx:enterprise-bug2015697_client_updates

Conversation

@lissyx
Copy link
Contributor

@lissyx lissyx commented Feb 16, 2026

No description provided.

@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch 6 times, most recently from 8b094c5 to 1bebedf Compare February 19, 2026 08:55
@lissyx lissyx self-assigned this Feb 19, 2026
@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch 12 times, most recently from 685eabd to e946ec7 Compare February 20, 2026 18:33
@lissyx
Copy link
Contributor Author

lissyx commented Feb 20, 2026

@lissyx lissyx requested a review from Mossop February 20, 2026 18:51
@lissyx lissyx marked this pull request as ready for review February 20, 2026 18:51
@lissyx lissyx requested a review from a team February 20, 2026 18:51
@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch from e946ec7 to af89d5a Compare February 20, 2026 18:51
@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch 2 times, most recently from 0ef58a1 to f95ba84 Compare February 23, 2026 12:31
@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch from f95ba84 to 78f1477 Compare February 25, 2026 12:48
@lissyx lissyx requested a review from gcp February 25, 2026 12:48
Copy link
Contributor

@1rneh 1rneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built this locally to test and I made a few observations, both shown in the following screenshots:

Expected design (theme difference irrelevant):

Image

Actual implementation:

  • The title and the spinner + "Checking for updates" UI is not in line vertically with the wordmark.
  • No gap between spinner and string
  • "Powered by Mozilla" is gone
Image
  • The "Checking for updates" UI might only displayed for less than half a second before the email form is shown. So in that case (which will be probably be the most prominent on) It currently looks like a glitch.
Screen.Recording.2026-03-02.at.14.58.20.mov

@lissyx
Copy link
Contributor Author

lissyx commented Mar 2, 2026

I built this locally to test and I made a few observations, both shown in the following screenshots:

Expected design (theme difference irrelevant):
Image

Actual implementation:

* The title and the spinner + "Checking for updates" UI is not in line vertically with the wordmark.

Will fix

* No gap between spinner and string

There is one, it's too small maybe?

* "Powered by Mozilla" is gone

Will fix

Image
* The "Checking for updates" UI might only displayed for less than half a second before the email form is shown. So in that case (which will be probably be the most prominent on) It currently looks like a glitch.

Unfortunately, either we introduce a useless delay here, or we directly remove the checking, or we live with "it looks like a glitch", because we show it during the time we do the check indeed. If the network or server is slow, it will be visible more, but if it's fast it's going to behave like that. And if we dont see it and network is not blazing fast, then people would end up on an empty screen?

Screen.Recording.2026-03-02.at.14.58.20.mov

@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch from 7426b0f to 96d4313 Compare March 2, 2026 16:00
@lissyx
Copy link
Contributor Author

lissyx commented Mar 2, 2026

I built this locally to test and I made a few observations, both shown in the following screenshots:
Expected design (theme difference irrelevant):
Image
Actual implementation:

* The title and the spinner + "Checking for updates" UI is not in line vertically with the wordmark.

Will fix

* No gap between spinner and string

There is one, it's too small maybe?

* "Powered by Mozilla" is gone

Will fix

All three should be fixed

@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch 3 times, most recently from 58e0bcd to 6f8dbd8 Compare March 2, 2026 16:48
@lissyx lissyx requested a review from 1rneh March 2, 2026 16:48
@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch 5 times, most recently from da7fdbd to 391b884 Compare March 3, 2026 15:30
Copy link
Contributor

@1rneh 1rneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'll be out until tomorrow afternoon, I commented on everything I noticed from another quick look.

@lissyx lissyx requested a review from 1rneh March 3, 2026 20:34
@lissyx
Copy link
Contributor Author

lissyx commented Mar 3, 2026

Capture d’écran du 2026-03-03 20-50-50 Capture d’écran du 2026-03-03 20-51-01 Capture d’écran du 2026-03-03 21-02-59 Capture d’écran du 2026-03-03 21-03-03 Capture d’écran du 2026-03-03 21-14-08 Capture d’écran du 2026-03-03 21-14-14

@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch 2 times, most recently from cafd7e8 to d06ba25 Compare March 3, 2026 21:44
Copy link
Contributor

@1rneh 1rneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing the screenshots. The UI changes look very correct now :)

The remaining comments address descriptive naming of methods and some small issues with the UI state changes.

@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch from d06ba25 to 6762e44 Compare March 4, 2026 15:42
@lissyx lissyx requested a review from gcp March 4, 2026 15:42
@lissyx lissyx force-pushed the enterprise-bug2015697_client_updates branch from 6762e44 to 1d3341f Compare March 4, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants