Support Storing and Deploying WebCompat Redash Queries#503
Conversation
ksy36
left a comment
ksy36
left a comment
There was a problem hiding this comment.
I left a few comments and also was wondering if having some tests would be helpful here, but otherwise looks good to me
jgraham
force-pushed
the
webcompat_redash
branch
from
58e25ae to
6785c72
Compare
|
I tried generating some unit tests for the RedashTemplateRenderer with Claude, and they're probably better than nothing, but I don't love them, so I didn't continue that path. I should probably work out if there's a strategy to get more useful coverage. More usefully I added the template rendering to the |
| redash_client: RedashClient, | ||
| redash_data: redashdata.RedashData, | ||
| dashboards_filter: Optional[set[str]], | ||
| write: bool, |
There was a problem hiding this comment.
looks like dashboards_filter is passed, but not used anymore? not sure if it will render all dashboards even though a specific dashboard arg is passed in
This allows the queries to be parameterised based on the metric definitions.
For the Comprehensive WebCompat Overview dashboard, and for the Bugs By Next Team and Action query which isn't really part of any dashboard.
This ensures that we're able to at least successfully render all the templates. It currently doesn't do any additional linting.
jgraham
force-pushed
the
webcompat_redash
branch
from
ea2a08e to
bdcee99
Compare
2 participants
Checklist for reviewer:
referenced, the pull request should include the bug number in the title)
.circleci/config.yml) will cause environment variables (particularlycredentials) to be exposed in test logs
telemetry-airflow
responsibly.
Note for deployments: In order to push images built by this PR, the user who merges the PR
must be in the telemetry Github team.
This is because deploys depend on the
data-eng-airflow-gcr CircleCI context.
See DENG-8850 for additional discussion.