Skip to content

Release note remove app#17241

Draft
wen-2018 wants to merge 2 commits into
mainfrom
release-note-remove-app
Draft

Release note remove app#17241
wen-2018 wants to merge 2 commits into
mainfrom
release-note-remove-app

Conversation

@wen-2018

Copy link
Copy Markdown
Collaborator

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

One-line summary

This PR can only be merged after #17240 is deployed.

Significant changes and points to review

  • removes release notes app entirely after DB clean up is complete.

Issue / Bugzilla link

#17225 (comment)

Testing

@janriokrause janriokrause left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor improvements:

  1. After rebasing and the previous PR has landed, please do not forget to git rm bedrock/releasenotes/migrations/0003_delete_productrelease.py.

  2. Remove releasenotes.ProductRelease \ from the dumpdata call in bin/export-db-to-sqlite.sh (line 196). It will break the export otherwise.

  3. Fix the stale # For release notes. comment on "www.mozilla.org" in _csp_img_src in bedrock/settings/__init__.py, or drop the entry if nothing else needs it. Probably @stevejalim knows best.

  4. Follow-up PR after this one merges: Remove django-memoize==2.3.1 from requirements/prod.in, then regenerate prod.txt + dev.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants