Bug 2050097 - Add AI engine classification#7451
Open
mandysGit wants to merge 1 commit into
Open
Conversation
Standard8
requested changes
Jul 6, 2026
Standard8
left a comment
Member
There was a problem hiding this comment.
As discussed elsewhere, the fix here is correct, however due to our lack of fallback (#[serde(other)]), this won't work for existing clients that have already been shipped.
I think we should delay this until we need search-config-v3. In the meantime the relevant engine could be switched to "unknown".
Setting to "request changes" to clear from review queue.
| /// The classification of search engine according to the main search types | ||
| /// (e.g. general, shopping, travel, dictionary). Currently, only marking as | ||
| /// a general search engine is supported. | ||
| /// (e.g. general, ai, and unknown). |
Member
There was a problem hiding this comment.
The types that I put in previously were intended as examples, rather than exact definitions. I don't think we want to put ourselves in a situation of having to update documentation that's defined elsewhere, so how about something like:
/// The classification of search engine according to the main search types
/// (e.g. general, shopping, travel, dictionary; for exact definitions see `SearchEngineClassification`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.