Skip to content

Bug 2050097 - Add AI engine classification#7451

Open
mandysGit wants to merge 1 commit into
mozilla:mainfrom
mandysGit:ai-classification
Open

Bug 2050097 - Add AI engine classification#7451
mandysGit wants to merge 1 commit into
mozilla:mainfrom
mandysGit:ai-classification

Conversation

@mandysGit

Copy link
Copy Markdown
Contributor

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mandysGit mandysGit requested a review from Standard8 June 25, 2026 19:53

@Standard8 Standard8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed elsewhere, the fix here is correct, however due to our lack of fallback (#[serde(other)]), this won't work for existing clients that have already been shipped.

I think we should delay this until we need search-config-v3. In the meantime the relevant engine could be switched to "unknown".

Setting to "request changes" to clear from review queue.

/// The classification of search engine according to the main search types
/// (e.g. general, shopping, travel, dictionary). Currently, only marking as
/// a general search engine is supported.
/// (e.g. general, ai, and unknown).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types that I put in previously were intended as examples, rather than exact definitions. I don't think we want to put ourselves in a situation of having to update documentation that's defined elsewhere, so how about something like:

/// The classification of search engine according to the main search types
/// (e.g. general, shopping, travel, dictionary; for exact definitions see `SearchEngineClassification`).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants