Bug 1997373 - Store original pref values for Fenix Gecko integration #7122
+847
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohall-m
force-pushed
the
1997373
branch
5 times, most recently
from
ae5eaf6 to
181a21d
Compare
Author
|
Hi @jeddai and @freshstrangemusic , Please take a look at this when you have a chance! I don't have the right repo access to request in the Reviewers panel. |
jeddai
added
nimbus
ohall-m
commented
Dec 10, 2025
Author
ohall-m
left a comment
ohall-m
left a comment
There was a problem hiding this comment.
Thanks for all the thoughtful comments! Really appreciate all of the rust explanations especially.
I have a couple of ToDos I marked in the comments that I'm still working through. I'm submitting the comments on what has changed to help keep the changes organized for now.
Author
|
First draft comments should be addressed now, thanks! |
freshstrangemusic
previously requested changes
Dec 19, 2025
5 tasks
mergify
bot
dismissed
freshstrangemusic’s stale review
The pull request has been modified, dismissing previous reviews.
5 tasks
ohall-m
force-pushed
the
1997373
branch
2 times, most recently
from
e255f19 to
75aac28
Compare
ohall-m
force-pushed
the
1997373
branch
2 times, most recently
from
3aca4a2 to
0200d98
Compare
Contributor
|
|
…ation This patch begins storing a `Vec<PreviousGeckoPrefState>` on `ExperimentEnrollment` when it is of type `EnrollmentStatus::Enrolled` for managing the original value of gecko prefs used in an experiment. The public APIs it opens are `registerPreviousGeckoPrefStates` and `getPreviousGeckoPrefStates`.
Author
|
Thanks, updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch begins storing a
PreviousGeckoPrefStateonExperimentEnrollmentwhen it is of typeEnrollmentStatus::Enrolledfor managing the original value of gecko prefs used in an experiment.It also introduces
PreviousState::GeckoPrefto hold Gecko original preference values for Gecko pref based experiments.The public APIs it opens are
registerPreviousGeckoPrefStatesandgetPreviousGeckoPrefState.The goal of this patch is to appropriately store the original Gecko preference value to help when exiting an experiment.
Current idea is that it will be set similarly as
unenrollForGeckoPrefin this patch D257390, but for the positive case. Bug 2003370 will use this to properly consume these values when appropriate.Pull Request checklist
[ci full]to the PR title.