Output list instead of table

[fregante]

• Fixes Output as list, not table #5423

Before

This isn't even the full table, it doesn't fit on my screen

After

[fregante]

@rpl @willdurand I believe the improvements here are evident from my screenshots:

• the output is shorter
• there's no duplicate explanation
  
• there's no bad wrapping of long text
  
• paths are always clickable
  
• row and col are part of the path, meaning IDEs can reach them in the same click
  
• the table implementation isn't even right because the error/warning tables are not aligned
  

The only reason not to move forward with this is because it already works, albeit in this suboptimal fashion. Since I'm currently available to work on this, allow me to complete this change and merge this PR. I don’t really like keeping PRs open for years

[Rob--W]

Thanks for improving the readability and dropping one dependency. We're willing to switch the output format.

Could you adjust the text and update the tests so that they pass?

Thanks for this, and apologies for the review delay!

[fregante]

Great, let's see if I have time this month

[willdurand]

I know we haven't been very responsive here. Should we attempt to change the output or should we drop the idea?

[fregante]

This month I'll be a bit busy. If the changes are purely esthetic please take it over or assign Copilot to finish it up.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (665acc3) to head (feda392).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5426      +/-   ##
==========================================
- Coverage   98.79%   98.79%   -0.01%     
==========================================
  Files          51       51              
  Lines        2905     2893      -12     
  Branches      895      897       +2     
==========================================
- Hits         2870     2858      -12     
  Misses         35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[willdurand]

This is obvious in the tests but it wasn't when I looked at the screenshots.. The description is gone. @fregante was that intended?

[fregante]

Most likely not intentional, it should appear just after the message as in the original order. In some cases it does seem to be identical to the message so it should likely be dropped there instead of repeating it.

[Rob--W]

@rpl @willdurand and I reviewed the result together.

Observed changes, explicitly approved:

• Previously the text was wrapped. Now it is not. We are okay with it. If there is demand for the functionality (e.g. through a bug report in the future) we can reconsider at that time.

Requested changes to behavior:

• Append (warning) / (error) (or prepend warning/error) to the error code so that it is more obvious whether a code is a warning/error when the user looks at a fragment of the output.
• Remove indentation level (so that the error code and description does not have space at the left).
• Make it more obvious that the file is the file where the error occurred.