Bug 2008308 - fix(rust): ignore core::result::unwrap_failed

[ErichDonGubler]

No description provided.

[biancadanforth]

Hello @ErichDonGubler ! Thanks for the PR.

Can you follow the process described in the Socorro docs: How to make a signature generation change? I think you've done some of this, but most notably: the bug/PR needs a description of the change and a couple more example signatures for testing.

I'll be following the same docs in terms of how to review the PR. Once the bug is updated with a couple more examples, I can run it through signature generation for your review on the updated signatures.

Aside: I noticed CI had failed initially, but the failure looked unrelated, and retriggering the run made it pass. I'll look into the flaky test failure separately.

[biancadanforth]

I looked through Crash Stats for some signatures that had this substring, and I picked a crash ID from a few different ones to run through signature generation based on this PR branch. @ErichDonGubler , do these signature changes look good to you?

I'm still waiting for you to update the description of the bug (mentioned in my review comment above).

Also, I was a bit confused by this comment in the bug -- the signature in this URL doesn't contain core::result::unwrap_failed. Am I missing something?

app@socorro:/app$ cat crashids.txt | socorro-cmd signature
Crash id: 84b12a9d-cedb-4ffb-80fb-694560260109
Original: core::result::unwrap_failed | logins::create_login_store_with_nss_keymanager
New:      logins::create_login_store_with_nss_keymanager
Same?:    False

Crash id: ef3fcb48-6abc-46de-9a91-654a00260109
Original: core::result::unwrap_failed | webrender::renderer::upload::copy_into_staging_buffer
New:      webrender::renderer::upload::copy_into_staging_buffer
Same?:    False

Crash id: f48cc132-39da-42f0-9746-21acc0260104
Original: OOM | unknown | core::result::unwrap_failed | webrender::bump_allocator::BumpAllocator::new
New:      OOM | unknown | webrender::bump_allocator::BumpAllocator::new
Same?:    False

[ErichDonGubler]

Hey there, sorry for taking so long to get back. I've had a lot of competing high priorities come up suddenly for me in the last little while. 😅

I looked through Crash Stats for some signatures that had this substring, and I picked a crash ID from a few different ones to run through signature generation based on this PR branch. @ErichDonGubler , do these signature changes look good to you?

They do, thank you!

I'm still waiting for you to update the description of the bug (mentioned in my review comment above).

Also, I was a bit confused by this comment in the bug -- the signature in this URL doesn't contain core::result::unwrap_failed. Am I missing something?

…

I think my edits to comment 1 (and now the description; see also comment 3) fulfill the criteria? PTAL!

[smarnach]

Thanks for the updates to the bug! This looks good to me.