Reduce max table expiration days from 10,000 to 9,985#833
Open
Reduce max table expiration days from 10,000 to 9,985#833
Conversation
Tables can have a maximum of 10,000 partitions, but when partitions expire they apparently continue to count toward the table's partition quota for up to 14 days afterwards (7 days of time travel and 7 days of fail-safe), and I subtracted one additional day just to make sure we don't hit the table partition limit.
Integration report for "Reduce max table expiration days from 10,000 to 9,985."
|
Contributor
Author
|
Note that there's some discussion in the associated probe-scraper PR about whether this is worth doing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables can have a maximum of 10,000 partitions, but when partitions expire they apparently continue to count toward the table's partition quota for up to 14 days afterwards (7 days of time travel and 7 days of fail-safe), per the BigQuery docs:
And I subtracted one additional day just to make sure we don't hit the table partition limit.
This goes along with mozilla/probe-scraper#840.
Checklist for reviewer:
./.github/push-to-trigger-integration <username>:<branchname>For glean changes:
templates/include/glean/CHANGELOG.mdFor modifications to schemas in restricted namespaces (see
CODEOWNERS):