Show signoff history#3053
Closed
AMUZY wants to merge 2 commits intomozilla-releng:mainfrom
Closed
Conversation
AMUZY
requested review from
gabrielbusta,
gbrownmozilla and
jcristau
as code owners
Contributor
|
Unfortunately, this was missed when it was ready for review and is now way out of date. I'm going to close it, but would be happy to re-open and ensure it gets looked at quickly if it is rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS NOT READY YET though because there are still some hard coded values.
I opened it so it can be reviewed before I proceed further.
It fixes THIS PR opened by @bhearsum.
Can now view signoff history.
The information displayed here :
The MUI table component came in handy here :
You could search for your user with the browser search tool (like normal) :
Let me know if this was a good innovation. Also if there's more important data that should be in the table. I'll need your review @bhearsum @gabrielbusta to proceed further