Skip to content

Fix - don't use validate legacy for windowstime #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markcor merged 1 commit into from
Feb 24, 2026
Merged

Fix - don't use validate legacy for windowstime #1078

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/windowstime/manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,14 @@
}

if $timezone {
validate_legacy(String, 'validate_re', $timezone, $timezones, 'The specified string is not a valid Timezone')
# Native validation (no stdlib validate_legacy / validate_re).
# If timezones is provided (and non-empty), require timezone be one of them.
if $timezones and $timezones != [] {
unless $timezone in $timezones {
fail('The specified string is not a valid Timezone')
}
}

if $timezone != $facts['timezone'] {
$system32dir = $facts['os']['windows']['system32']
exec { "${system32dir}\\tzutil.exe /s \"${timezone}\"":
Expand Down