chore: Use step summary (or uploaded artifact) rather than comments only#132
Open
grahamalama wants to merge 1 commit intomainfrom
Open
chore: Use step summary (or uploaded artifact) rather than comments only#132grahamalama wants to merge 1 commit intomainfrom
grahamalama wants to merge 1 commit intomainfrom
Conversation
grahamalama
changed the title
When we post helm diff comments in PRs, the diffs can be long and are split up across many comments. In this commit, we instead send the diff to the job summary or upload it as an artifact if it's too large, then link to that summary or artifact in the comment instead. This will hopefully lead to fewer comments and unified diffs.
grahamalama
force-pushed
the
helm-diff-as-job-output
branch
from
44e34a1 to
274813e
Compare
Contributor
Author
|
See an example of the posted comment and summary output here |
grahamalama
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we post helm diff comments in PRs, the diffs can be long and are split up across many comments. In this PR, we instead send the diff to the job summary (or upload it as an artifact if it's too large), then link to that summary or artifact in the comment instead. This will hopefully lead to fewer comments and unified diffs.