Conversation
cbddf51 to
50fcdc1
Compare
grahamalama
approved these changes
Jan 29, 2026
grahamalama
reviewed
Jan 29, 2026
Contributor
grahamalama
left a comment
There was a problem hiding this comment.
IIUC:
- The outer while loop looks at all values files that aren't
values.{yml,yaml}(for chart types 1, 2, and 3) - in that loop, we render charts for types 1 and 2
- in the inner while loop (
while read region_values_file;), we render additional charts for the regional overrides (type 3)
…values files
The validate-k8s-manifests workflow does not respect region specific
values files as it should.
We support 3 "types" of naming patterns for values files at the moment:
* GPA
Pattern: %domain%\.values\.(yaml|yml)
e.g.: webservices.values.yaml
* tenant (env in primary region)
Pattern: values(-ent)?-[[:alnum:]]+\.(yaml|yml)
e.g.: values-prod.yaml
* Tenant (env in additional region)
Pattern: values(-ent)?-[[:alnum:]]+((-[[:alnum:]]+){2})?\.(yaml|yml)
e.g.: values-prod-europe-west1.yaml
We generally consider case 3 to be an additional values file that's
merged on top of case 2's values file (e.g. in ArgoCD). This change
renders case 3 to an extra artifact to make validation work as expected.
50fcdc1 to
e703171
Compare
dlactin
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validate-k8s-manifests workflow does not respect region specific
values files as it should.
We support 3 "types" of naming patterns for values files at the moment:
GPA
Pattern: %domain%.values.(yaml|yml)
e.g.: webservices.values.yaml
tenant (env in primary region)
Pattern: values(-ent)?-[[:alnum:]]+.(yaml|yml)
e.g.: values-prod.yaml
Tenant (env in additional region)
Pattern: values(-ent)?-[[:alnum:]]+((-[[:alnum:]]+){2})?.(yaml|yml)
e.g.: values-prod-europe-west1.yaml
We generally consider case 3 to be an additional values file that's
merged on top of case 2's values file (e.g. in ArgoCD). This change
renders case 3 to an extra artifact to make validation work as expected.